WebGPU: Instancing #23835
Merged
WebGPU: Instancing #23835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
Apr 4, 2022
LeviPesin
reviewed
Apr 4, 2022
LeviPesin
reviewed
Apr 4, 2022
LeviPesin
reviewed
Apr 4, 2022
LeviPesin
reviewed
Apr 4, 2022
LeviPesin
reviewed
Apr 4, 2022
|
@mrdoob What do you think about the Skinning example? it doesn't follow the API exactly but it might be useful? |
Mugen87
reviewed
Apr 4, 2022
|
|
||
| child.material = new Nodes.MeshStandardNodeMaterial(); | ||
|
|
||
| child.isInstancedMesh = true; |
There was a problem hiding this comment.
Well, this is more or less a workaround until we figure out a better way to combine skinning + instancing. For now, I think it's okay.
There was a problem hiding this comment.
Well, this is more or less a workaround until we figure out a better way to combine skinning + instancing. For now, I think it's okay.
What do you think about an API like this?
const instanceCount = 10;
const instancedObj3d = new InstanceObject3D( mesh || sprite3d || skinnedMesh, instanceCount );
scene.add( instancedObj3d );
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* WebGPU: instancing support * add instancing examples * update thumbnails * cleanup * cleanup * use native inverseSqrt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support to instancing and improvements in
Matrix*NodeandBufferNodeofNodeMaterial.Examples:
Meshhttps://raw.githack.com/sunag/three.js/dev-instance/examples/webgpu_instance_mesh.html
Skinning( sharing the same Skeleton & animation )https://raw.githack.com/sunag/three.js/dev-instance/examples/webgpu_skinning_instancing.html
This contribution is funded by Google via Igalia.