Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebXRManager: Fix for hand controllers #23830

Merged
merged 2 commits into from
Apr 2, 2022
Merged

WebXRManager: Fix for hand controllers #23830

merged 2 commits into from
Apr 2, 2022

Conversation

cabanier
Copy link
Contributor

@cabanier cabanier commented Apr 1, 2022

When the hand controllers go in and out of view, the browser is allowed to remove them from the input sources list.
The current implementation in the Oculus quest alway returns them, but that is not true going forward or in devices such as the Hololens.

On those devices, the right hand will be assigned the left controller which will cause it to deform.

This fix addresses that issues by looking up the correct controller instead of blindly using the index.

@mrdoob mrdoob added this to the r140 milestone Apr 2, 2022
@mrdoob mrdoob changed the title Fix for hand controllers WebXRManager: Fix for hand controllers Apr 2, 2022
@mrdoob mrdoob merged commit d0dc080 into mrdoob:dev Apr 2, 2022
@mrdoob
Copy link
Owner

mrdoob commented Apr 2, 2022

Thanks!

@hybridherbst
Copy link
Contributor

hybridherbst commented Apr 2, 2022

@cabanier this sounds very similar to

do you think it's the same issue? We also had to fix this for Hololens and also for phone-AR multitouch but it never got merged...

Another related issue where your input would be appreciated is

@cabanier
Copy link
Contributor Author

cabanier commented Apr 3, 2022

@hybridherbst yes, this is the same issue and I verified that the same problem existed on the Hololens.
We're using the same backend as HL which is likely why both devices have this problem.

There's still an issue where the pointing ray gets duplicated every time a hand goes out of view. I didn't get a chance to look into that yet.

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* Fix for hand controllers

* Address review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants