WebXRManager: Fix input sources being sent to wrong controllers (touch AR)

[marwie]

Related issue: #23187

Description

Adds array of input sources to keep track of controllers being still/currently used on inputSourcesChanged event.
This prevents mixup/re-ordering of touches in AR.

This contribution is funded by 🌵 needle.

[hybridherbst]

Might be superseded by

• WebXRManager: Fix for hand controllers #23830

but I still have to verify.

[mrdoob]

but I still have to verify

Let us know when you do 🙏

[hybridherbst]

Finally got hold of another Hololens 2, here's some findings:

• WebXRManager: Fix for hand controllers #23830 doesn't fix multitouch AR cases as it only deals with handedness; we rebased and adjusted our original changes and updated this PR here to fix that 🚀

• there's occassional TypeError: cannot read properties of null (reading 'assetUrl') in XRControllerModelFactory.js:276, not sure where that's suddenly coming from though

• there is a regression in WebXR pointer handling, when using Hololens 2 every time a hand leaves/enters the view a new VisualResponse (sphere + pointer) is spawned and stuck in the air. This wasn't the case ~r137. This affects all of the hands samples; for example here: https://threejs.org/examples/?q=hand#webxr_vr_handinput_pointerdrag. This doesn't affect Quest hands, only Hololens hands

• there's another regression (potentially, not sure if this was the case before already) in hand handling on both Quest and Hololens - when wildly clicking around on boxes in this demo https://threejs.org/examples/?q=hand#webxr_vr_handinput_pointerdrag, I can easily get the pointer click to be "stuck" (hand not pinching anymore but cube is following pointer).

cc @cabanier @mrdoob

Also noticed that, tangentially related,

• Inherit layers from parent object when creating hand and controller models #23279

is still open; the problem still exists (no way to set raycast / visibility layers on child objects since there's no callback when the controller/hands model is actually spawned). Problematic on both Quest and Hololens.

[hybridherbst]

Opened one of the regression issues as

• VisualResponse objects get created over and over when WebXR hands are entering/leaving the view #24071

[hybridherbst]

@mrdoob @cabanier any input here? Would be great to have multi-controller AR (multitouch, multiple controllers without handedness) working again.

[cabanier]

@mrdoob @cabanier any input here? Would be great to have multi-controller AR (multitouch, multiple controllers without handedness) working again.

The change looks reasonable. What systems did you try it on?

[hybridherbst]

• Quest 2 (Hands + Controllers)
• Hololens 2 (both VR and AR mode with hands)
• a couple of phones (Multitouch when using WebXR in immersive-ar mode)

[mrdoob]

Thanks!