switched PMREM to ShaderMaterial #23561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
WestLangley
reviewed
Feb 23, 2022
| @@ -753,7 +751,7 @@ function _getBlurShader( lodMax, width, height ) { | |||
|
|
|||
| function _getEquirectShader() { | |||
|
|
|||
| const shaderMaterial = new RawShaderMaterial( { | |||
| const shaderMaterial = new ShaderMaterial( { | |||
There was a problem hiding this comment.
_getEquirectShader() does not return a shader. It returns a material.
_getCommonVertexShader() returns a shader.
There was a problem hiding this comment.
@mrdoob likewise _getCubemapShader()
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23558
Description
@mrdoob; your last fix was still not working because it couldn't properly switch between WebGL1 and WebGL2: #23558 (comment)
I went ahead and did what @Mugen87 suggested; looks like my fears may have been baseless. Still, would be great to have a few more people test it out and do those pixel comparison images.