Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMREMGenerator: Cleanup #23558

Merged
merged 2 commits into from
Feb 23, 2022
Merged

PMREMGenerator: Cleanup #23558

merged 2 commits into from
Feb 23, 2022

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Feb 22, 2022

Related issue: #23556

Description

@mrdoob mrdoob added this to the r138 milestone Feb 22, 2022
@mrdoob mrdoob requested a review from Mugen87 February 22, 2022 22:17
@mrdoob
Copy link
Owner Author

mrdoob commented Feb 22, 2022 •
edited
Loading

As far as I understand, this PR removes support for anisotropy-proof PMREM in WebGL1.
But I question if that's something we need to support... As far as I understand the GPUs affected support WebGL2 without issues.

@elalish
Copy link
Contributor

elalish commented Feb 22, 2022

I think you'll want to fix this while you're at it: #23556 (comment)

@mrdoob
Copy link
Owner Author

mrdoob commented Feb 22, 2022 •
edited
Loading

Hmm, which RawShaderMaterial is using texture2DGradEXT?

As far as I can see texture2DGradEXT was added to cuve_uv_reflection_fragment.glsl.js.

The RawShaderMaterial in _getBlurShader() doesn't seem to need the shaderTextureLOD extension either?

https://github.com/elalish/three.js/blob/f101a208051b517bd5ebcd12d928a07e5a36baf9/src/extras/PMREMGenerator.js#L665-L758

@mrdoob
Copy link
Owner Author

mrdoob commented Feb 22, 2022

Never mind, I just saw the #include <cube_uv_reflection_fragment>.

@mrdoob
Copy link
Owner Author

mrdoob commented Feb 22, 2022

I think this solves the problem: da799bd

@mrdoob mrdoob merged commit 5b75dcb into dev Feb 23, 2022
@mrdoob mrdoob deleted the pmrem_cleanup branch February 23, 2022 00:04
@elalish elalish mentioned this pull request Feb 23, 2022
Merged
donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
@mrdoob @donmccurdy
PMREMGenerator: Cleanup (mrdoob#23558)
dc7af68 
* PMREMGenerator: Cleanup.

* PMREMGenerator: Added GL_EXT_shader_texture_lod to _getBlurShader() raw shader.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elalish elalish elalish left review comments

@Mugen87 Mugen87 Awaiting requested review from Mugen87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r138
Development

Successfully merging this pull request may close these issues.
2 participants
@mrdoob @elalish