Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support transmission roughness on WebGL1 #23460

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

haxiomic
Copy link
Contributor

@haxiomic haxiomic commented Feb 11, 2022

Related issue: #22009

Description

Enables transmission roughness on WebGL1 by flooring to power of two, extends #23452 (comment) following comment here #22731 (comment)

@mrdoob mrdoob added this to the r138 milestone Feb 11, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 11, 2022

Even better 👍

@mrdoob mrdoob merged commit a1fcf3f into mrdoob:dev Feb 11, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 11, 2022

Thanks!

This was referenced Feb 11, 2022
donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
* Support transmission roughness on WebGL1

* Update WebGLRenderer.js

Co-authored-by: mrdoob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants