Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Limited WebGL1 backwards compatibility for transmission. #23452

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Feb 10, 2022

Related issues: #22731 #23450

Description

Rather than completely removing transmission support in WebGL1, I think we can provide limited support by ignoring roughness (mipmapping).

Before After
Screen Shot 2022-02-10 at 10 29 13 AM Screen Shot 2022-02-10 at 10 26 42 AM

I've also increased the _transmissionRenderTarget resolution to 1x which fully solves issue 5 in #22009.

@mrdoob mrdoob added this to the r138 milestone Feb 10, 2022
@mrdoob mrdoob requested a review from Mugen87 February 10, 2022 15:39
@mrdoob
Copy link
Owner Author

mrdoob commented Feb 10, 2022

/cc @haxiomic

@mrdoob mrdoob merged commit 12ad8a3 into dev Feb 10, 2022
@mrdoob mrdoob deleted the transmission branch February 10, 2022 16:10
@mrdoob
Copy link
Owner Author

mrdoob commented Feb 10, 2022

@elalish FYI _transmissionRenderTarget is no longer 1024x1024.

@elalish
Copy link
Contributor

elalish commented Feb 10, 2022

Awesome! And I agree that full-res is the way to go; really you can only safely go lower if there's some roughness applied to the transmissive surface, or its geometry is complex. No good way to check for that.

donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
…n. (mrdoob#23452)

* WebGLRenderer: Limited WebGL1 backwards compatibility for transmission.

* Update WebGLRenderer.js

* Updated docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants