Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPUTextures: Fix Texture.image !== null #23436

Merged
merged 1 commit into from
Feb 6, 2022
Merged

WebGPUTextures: Fix Texture.image !== null #23436

merged 1 commit into from
Feb 6, 2022

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Feb 6, 2022

Related issue: #22846

Description

Fix conditional.

This contribution is funded by Google via Igalia.

takahirox
takahirox approved these changes Feb 6, 2022
View reviewed changes
Copy link
Collaborator

@takahirox takahirox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me because Texture.DEFAULT_IMAGE is null now #23421

@Mugen87 Mugen87 added this to the r138 milestone Feb 6, 2022
@Mugen87 Mugen87 merged commit e619fe5 into mrdoob:dev Feb 6, 2022
donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
@sunag @donmccurdy
Fix Texture.image !== null <- mrdoob#22846 (mrdoob#23436)
f466b6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirox takahirox takahirox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r138
Development

Successfully merging this pull request may close these issues.
3 participants
@sunag @takahirox @Mugen87