Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLTextures: Fix empty image check. #23421

Merged
merged 2 commits into from
Feb 4, 2022
Merged

WebGLTextures: Fix empty image check. #23421

merged 2 commits into from
Feb 4, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 3, 2022

Related issue: -

Description

It is necessary to check for null and not undefined since Texure.image refers to Source.data now.

@Mugen87 Mugen87 added this to the r138 milestone Feb 3, 2022
@mrdoob mrdoob merged commit a0b7f93 into mrdoob:dev Feb 4, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 4, 2022

Thanks!

@joshuaellis joshuaellis mentioned this pull request Mar 1, 2022
16 tasks
donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
* WebGLTextures: Fix empty image check.

* Texture: Update value of DEFAULT_IMAGE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants