Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLMesh: Render number input values. #23381

Merged
merged 1 commit into from
Jan 31, 2022
Merged

HTMLMesh: Render number input values. #23381

merged 1 commit into from
Jan 31, 2022

Conversation

zz85
Copy link
Contributor

@zz85 zz85 commented Jan 29, 2022

Description

Render number input values in HTMLMesh. Fixes checking number type in html2canvas

Before
image

After
image

Render number input values in HTMLMesh
@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 29, 2022

This fixes #23130 (comment) 🎉

@Mugen87 Mugen87 added this to the r138 milestone Jan 30, 2022
@Mugen87 Mugen87 changed the title Render number input values in HTMLMesh.js HTMLMesh: Render number input values. Jan 31, 2022
@Mugen87 Mugen87 merged commit b3119d1 into mrdoob:dev Jan 31, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jan 31, 2022

Thanks!

donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
Render number input values in HTMLMesh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants