-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lil-gui 0.11.0 → 0.16.0 #23130
lil-gui 0.11.0 → 0.16.0 #23130
Conversation
Happy new year George! |
It seems the broke the GUI in https://raw.githack.com/mrdoob/three.js/dev/examples/webxr_vr_layers.html.
|
@Mugen87 ooh, thanks for the catch! Is there an easy way for me to debug this without the Oculus browser? Also, do you mind taking a screenshot? |
@georgealways Never mind! The issue was in |
@Mugen87 oh nice, glad you tracked it down |
No earth-shattering changes (here's the full changelog). Mostly fixes and a little more dat.gui parity.
I would say these are the top 5 additions since 0.11.0:
onFinishChange
toController
andGUI
.gui.show()
andhide()
.All told, the library has grown by ~0.93kb minified and ~0.11kb gzipped.
If you want to take a close look at the changes, this is a diff of the built source between both versions. (That site's not the greatest, but I don't know of a way to restrict GitHub's "compare" view to my src directory?)
I tested out a handful of examples for sanity, but not exhaustively.
Anyway, lemme know how that all looks, and happy new year!