Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lil-gui 0.11.0 → 0.16.0 #23130

Merged
merged 11 commits into from
Jan 3, 2022
Merged

lil-gui 0.11.0 → 0.16.0 #23130

merged 11 commits into from
Jan 3, 2022

Conversation

georgealways
Copy link
Contributor

No earth-shattering changes (here's the full changelog). Mostly fixes and a little more dat.gui parity.

I would say these are the top 5 additions since 0.11.0:

  • Number input fields can be dragged vertically.
  • Number input fields show a better keyboard on iOS.
  • Added onFinishChange to Controller and GUI.
  • Added gui.show() and hide().
  • Minor CSS bug fixes, better CSS minification.

All told, the library has grown by ~0.93kb minified and ~0.11kb gzipped.

0.11.0 = 28.12kb, 8.17kb gzipped
0.16.0 = 29.05kb, 8.28kb gzipped

If you want to take a close look at the changes, this is a diff of the built source between both versions. (That site's not the greatest, but I don't know of a way to restrict GitHub's "compare" view to my src directory?)

I tested out a handful of examples for sanity, but not exhaustively.

Anyway, lemme know how that all looks, and happy new year!

@WestLangley WestLangley added this to the r137 milestone Dec 31, 2021
@mrdoob mrdoob merged commit 3dd2a40 into mrdoob:dev Jan 3, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jan 3, 2022

Happy new year George!

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 15, 2022

It seems the broke the GUI in https://raw.githack.com/mrdoob/three.js/dev/examples/webxr_vr_layers.html.

lil-gui is used here in VR to control the distance of UI elements from the user. The lil-gui container is still visible however the value of eyeChartDistanceFt is missing now. Tested on a Quest 2 with latest Oculus browser. It still works in prod: https://threejs.org/examples/webxr_vr_layers

@georgealways
Copy link
Contributor Author

@Mugen87 ooh, thanks for the catch! Is there an easy way for me to debug this without the Oculus browser? Also, do you mind taking a screenshot?

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 31, 2022

@georgealways Never mind! The issue was in THREE.HTMLMesh.

@georgealways
Copy link
Contributor Author

@Mugen87 oh nice, glad you tracked it down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants