Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the recent changes in three.js have broken the RoughnessMipmapper: I was getting errors like this in Firefox where the GL errors are a bit more verbose than Chrome:
I've got it all working now in MV using this change. It changes the behavior of FramebufferTexture a bit, so that it allocates during
uploadTexture
and then only fills in data duringcopyFramebufferToTexture
, instead of doing the allocation there. This is important because I call this function in a loop to fill each mip level, and I think the reallocations were the problem.Anyway, @Mugen87 @mrdoob please give this some scrutiny, since I'm not sure what else this might affect.