Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Specify the raycaster recursive flag #22500

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

WestLangley
Copy link
Collaborator

Follow-on to #22460, which changed the default value.

In raycaster.intersectObjects(), if the recursive flag was true, I left it as-is.

(Since this is an example, I think it is best to specify the flag -- especially since there has been an API change.)

If the recursive flag was false, I left it as-is.

If the recursive flag was not specified, I set it to false, because that was the default value prior to #22460.

Thing is, I am a bit surprised at the number of false settings. Presumably, that is what was intended...

@WestLangley WestLangley added this to the r133 milestone Sep 7, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 7, 2021

In raycaster.intersectObjects(), if the recursive flag was true, I left it as-is.

After some time, I suggest to reconsider this point and only set the flag if it is different from the default value. But as you pointed out, it makes sense to explicitly specify the value now because of the API change.

@mrdoob mrdoob merged commit e30436d into mrdoob:dev Sep 7, 2021
@mrdoob
Copy link
Owner

mrdoob commented Sep 7, 2021

Thanks!

@WestLangley WestLangley deleted the dev-examples_intersects branch September 7, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants