Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raycaster: Set recursive default value to true #22460

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Raycaster: Set recursive default value to true #22460

merged 2 commits into from
Sep 7, 2021

Conversation

WestLangley
Copy link
Collaborator

As proposed in #21278.

@WestLangley WestLangley added this to the r133 milestone Aug 30, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 30, 2021

This change will also require to update the examples.

@WestLangley
Copy link
Collaborator Author

@mrdoob What do you think?

@mrdoob
Copy link
Owner

mrdoob commented Sep 7, 2021

Sounds good to me! 👍

@mrdoob mrdoob merged commit 147ded2 into mrdoob:dev Sep 7, 2021
@mrdoob
Copy link
Owner

mrdoob commented Sep 7, 2021

Thanks!

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 7, 2021

Updated the migration guide: https://github.com/mrdoob/three.js/wiki/Migration-Guide#132--133

@WestLangley Are you going to update the examples?

@WestLangley
Copy link
Collaborator Author

@Mugen87 OK

@WestLangley WestLangley mentioned this pull request Sep 7, 2021
Merged
@WestLangley WestLangley deleted the dev_recursive branch September 16, 2021 00:15
@joshuaellis joshuaellis mentioned this pull request Sep 18, 2021
Closed
23 tasks
@wooster0 wooster0 mentioned this pull request Feb 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r133
Development

Successfully merging this pull request may close these issues.
3 participants
@WestLangley @Mugen87 @mrdoob