Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeMaterial: Material.onBeforeRender() #22417

Merged
merged 7 commits into from
Sep 6, 2021
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 25, 2021

Description

The new NodeMaterial system work isolate of WebGLRenderer for creating of normalView, positionView and others for that the same code can be work in WebGPURenderer too.

For this done correctly, is needed a frame update for the nodes, this update can be done in with Material.onUpdate() or Mesh.onBeforeRenderer() for example.

Material.onUpdate(): was my suggestion, this new feature is much similar with the recently implemented Material.onBuild() #21117

WebGL NodesMaterial support

  • normal

Update webgl_materials_standard_nodes example.

@sunag sunag changed the title NodeMaterial: Material.onUpdate() and updates NodeMaterial: Material.onUpdate() Aug 31, 2021
@mrdoob mrdoob added this to the r133 milestone Sep 6, 2021
@mrdoob mrdoob merged commit 53e3d53 into mrdoob:dev Sep 6, 2021
@mrdoob
Copy link
Owner

mrdoob commented Sep 6, 2021

Thanks!

@sunag sunag changed the title NodeMaterial: Material.onUpdate() NodeMaterial: Material.onBeforeRender() Sep 6, 2021
@sunag sunag deleted the dev-igalia-3 branch September 27, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants