Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: NodeMaterial #21117

Merged
merged 14 commits into from
Apr 20, 2021
Merged

WebGLRenderer: NodeMaterial #21117

merged 14 commits into from
Apr 20, 2021

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jan 20, 2021

No description provided.

@sunag
Copy link
Collaborator Author

sunag commented Feb 6, 2021

Simple diffuse using new NodeMaterial system for WebGL
cc @mrdoob @Mugen87

Approach here: b9a0cde

https://raw.githack.com/sunag/three.js/nodematerial-webgl/examples/webgl_materials_standard_nodes.html

image

@mrdoob mrdoob added this to the r126 milestone Feb 17, 2021
@MichaelWang2021
Copy link

MichaelWang2021 commented Feb 20, 2021

does anyone can share insights on the performance issues incurred when using Nodematerial (https://threejs.org/examples/?q=node#webgl_materials_nodes, firefly part of codes) and MeshStardardMaterial (native in Gltf) in one scene? we are using r.116 version, simply mixing nodematerial and standard material in rendering loop.

even access the final scene from laptop chrome, FPS is significantly lower, left alone mobile phone.

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 20, 2021

@MichaelWang2021 Please do not hijack this thread. It's best if you ask your question at the forum.

@sunag
Copy link
Collaborator Author

sunag commented Feb 20, 2021

@MichaelWang2021 Performance issue can be very relative, so much so that this system uses a approach very different for build the shader... When opening a topic in the forum show examples and values related, otherwise we cannot make a serious analysis of this issue.

@sunag sunag requested a review from Mugen87 April 19, 2021 14:15
src/materials/Material.js Outdated Show resolved Hide resolved
@sunag sunag marked this pull request as ready for review April 19, 2021 16:17
@mrdoob mrdoob merged commit f2e4e0f into mrdoob:dev Apr 20, 2021
@mrdoob
Copy link
Owner

mrdoob commented Apr 20, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants