Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshLambertMaterial: honor the physicallyCorrectLights flag when using a light map #22397

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

WestLangley
Copy link
Collaborator

@WestLangley WestLangley commented Aug 23, 2021

Follow-on to #22393.

For MeshLambertMaterial, the light map intensity is no longer scaled by the artist-friendly factor of PI when .physicallyCorrectLights is true.

@WestLangley WestLangley added this to the r132 milestone Aug 23, 2021
@WestLangley
Copy link
Collaborator Author

@Mugen87 I had hoped to move this logic out of the shaders and into the render, but the renderer requires some refactoring to do so. So for now, it remains in the shaders.

@mrdoob mrdoob merged commit f65415c into mrdoob:dev Aug 23, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 23, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants