Core: Remove artist-friendly factor of PI from shaders #22393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the artist-friendly factor of
PI
from the shaders, and moves it into the renderer, instead.Now, the factor is computed once per frame instead of once per fragment.
Previously,
MeshLambertMaterial
ignored the.physicallyCorrectLights
flag, so when the flag was set,MeshLambertMaterial
rendered more brightly thanMeshPhongMaterial
by a factor ofPI
.Only users who use
MeshLambertMaterial
while setting the.physicallyCorrectLights
flag totrue
will see a change.