Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshPhysicalMaterial: Promote ior to a material property #22238

Merged
merged 3 commits into from
Aug 2, 2021

Conversation

WestLangley
Copy link
Collaborator

As discussed in #22156 (comment).

Follow-on to #20322.

Formerly, reflectivity was a property of MeshPhysicalMaterial, and ior was provided for convenience as a setter/getter.

In this PR, ior is promoted to a property of the material.

reflectivity is retained as a setter/getter for backwards-compatibility -- at least for now.

@WestLangley WestLangley added this to the r132 milestone Aug 1, 2021
@mrdoob mrdoob merged commit 1fc7869 into mrdoob:dev Aug 2, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 2, 2021

Nice! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants