-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LDrawLoader: Further improve smooth normal generation performance #22231
Conversation
Is it not sufficient with the current |
It does but it seems like a common case that the model you want to load would be saved in a different location from from the the canonical parts library. For example you currently can't load a model if your parts are stored at new LDrawLoader()
.setPath( '/path/to/models/' )
.setPartsLibraryPath( '/path/to/parts/library/' )
.load( 'my-model.mpd', result => {} ) |
Okay, I see it fine. |
Thanks! |
Ops! Missed that. Lets see if I can fix this... |
Seems like I can't... I reverted this PR and merged #22228. |
Heh sorry I should have marked as draft 😅 Here's a replacement PR: #22247 |
Merge #22228 first
Description
scope.triangles
array toscope.faces
With this change the total load time for the AT-ST model comes down from ~21 seconds to ~15 seconds compared to #22228.
There's a normal smoothing issue I found (not new) that I'll fix in another PR and I'll add
preloadMaterials
andsetPartsLibraryPath
functions so the loader is easier to use with the full LDraw parts library.cc @yomboprime