LDrawLoader: Improve smooth normal generation performance a bit #22228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: --
Description
Improves the generation time of smooth normals a bit by doing the following:
Object.keys
to get a single element from an object and instead use an immediately terminating for loop.With these changes the time to generate smooth normals goes from ~18.25 seconds to ~16 seconds when loading the AT-ST model. Nothing earth shattering but it is an improvement. I also switched to using typed arrays when generating geometry which saves another ~0.5 seconds on the AT-ST total processing time.
Next up I'm planning to bookkeep quads as 4 vertices so we can cut down on trying the smooth the plane diagonal as well as some other performance improvements. I also want to improve the ergonomics of the loader specifically relating to loading models with the LDraw parts library.
cc @yomboprime