WebGLRenderer, GLTFLoader: Clean up .vertexTangents removal. #22182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
This was referenced Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My change in #22146 did a bit too much, in trying to detect DirectX and OpenGL normal maps. I think it would be better to keep the
1, -1normalScale setting in GLTFLoader, since that is a better indicator of the normal map convention than.flipY. For glTF models, there should be no rendering differences between:devbranchBut for anyone using
.flipY=false(e.g. anything with Basis textures) for normal maps, but not using the OpenGL-style normal map convention, thedevbranch has a change that probably isn't desirable. This PR addresses that problem.I think it would be best to include this in r131 — if that's an issue, we can revert #22146 for now.
/cc @mrdoob @WestLangley