examples: fix dark theme on empty location hash #21932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
mrdoob
pushed a commit
that referenced
this pull request
Jun 2, 2021
Co-authored-by: Felix Mariotto <[email protected]>
mrdoob
reviewed
Jun 2, 2021
| @@ -383,6 +383,7 @@ iframe { | |||
| width: 100%; | |||
| height: 100%; | |||
| overflow: auto; | |||
| display: none; | |||
There was a problem hiding this comment.
Heh... This made all the projects in https://threejs.org/ disappear 😅
There was a problem hiding this comment.
I've reverted this line for now: 4f4c845
Would display: unset; work?
There was a problem hiding this comment.
@mrdoob I can't find the html file of the home page, it's not in the repo ?
We could replace this line with the following, since #viewer in the homepage is a div :
iframe#viewer {
display: none;
}There was a problem hiding this comment.
@mrdoob I can't find the html file of the home page, it's not in the repo ?
It's in the gh-pages branch.
We could replace this line with the following, since
#viewerin the homepage is adiv:
Sounds good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following #21929
Accessing https://threejs.org/examples with a browser with dark theme preference lead to the following output, whereas the body behind the empty iframe has a nice dark theme.
Commit demo ( depends on your browser settings ) : https://raw.githack.com/felixmariotto/three.js/dark_examples/examples/
@Mugen87 I have not been able to understand why the iframe was transparent when testing locally... most susprinsing.