-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix dark theme on empty location hash #21929
Conversation
It looks like this PR fixes https://threejs.org/examples/ as well. |
It's a change in |
Indeed you are right... It's weird I can't reproduce the wrong dark theme at https://threejs.org/examples/ locally I will investigate and make a new PR |
True. I wonder what makes the difference... |
TIL about unset 😮 |
I went down this rabbit hole before. |
Thanks! |
Co-authored-by: Felix Mariotto <[email protected]>
When accessing https://threejs.org/docs/ with a browser with dark theme preference, this is what shows up :
Tested on Chrome and Opera.
It seems that the iframe with an empty
src
has an opaque white background overlapping the body background.Original dark mode support PR by @mrdoob for reference : #17729
After the commit :