Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: Clean up. #21794

Merged
merged 1 commit into from
May 6, 2021
Merged

Examples: Clean up. #21794

merged 1 commit into from
May 6, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 6, 2021 •
edited
Loading

Related issue: #21712

Description

Ensures correct code style in new WebXR code.

@Mugen87 Mugen87 added this to the r129 milestone May 6, 2021
@Mugen87 Mugen87 merged commit a51bed7 into mrdoob:dev May 6, 2021
@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 6, 2021 •
edited
Loading

@fe1ixz @mrdoob While fixing the code style, I have noticed two things:

  • TOUCH_RADIUS is undefined.

three.js/examples/jsm/webxr/OculusHandModel.js

Line 88 in a51bed7

const indexSphere = new Sphere( pointerPosition, TOUCH_RADIUS );

  • handedness is undefined, too.

three.js/examples/jsm/webxr/XRHandMeshModel.js

Line 61 in a51bed7

console.warn( `Couldn't find ${jointName} in ${handedness} hand mesh` );

@mrdoob
Copy link
Owner

mrdoob commented May 6, 2021

  • TOUCH_RADIUS is undefined.

Fixed. 2c9b143

  • handedness is undefined, too.

@fe1ixz What's the fix for this one?

@mrdoob
Copy link
Owner

mrdoob commented May 6, 2021

  • handedness is undefined, too.

Should be fixed now. 571347f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r129
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @mrdoob