SSRPass: Reflector use clippingPlane. #21574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonnavis
force-pushed
the
SSRpassReflectorClippingPlanePr
branch
from
4adce79 to
ec49a1e
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PRs #21403 #21537 solved the problem of the correct depth, but because Oblique Near-Plane Clipping was turned off, another problem was introduced: if there are objects between the
virtualCameraand thegroundReflector, errors will be displayed.In the past two months, I have been keep thinking about how to compensate for the depth deviation caused by Oblique Near-Plane. Although have learnt something, I still haven't fully understood and found a suitable compensation method.
But in the end, recalled that there are clipping demos in exmaples, and turned out that there is no need for complex Oblique Near-Plane algorithms at all, threejs already has global clippingPlane ( which not influence
depthTexture) and I used it instead.before vs after
