Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSM: Revert to *.prototype.is* = true #21378

Merged
merged 1 commit into from
Mar 1, 2021
Merged

JSM: Revert to *.prototype.is* = true #21378

merged 1 commit into from
Mar 1, 2021

Conversation

linbingquan
Copy link
Contributor

Related issue: #21293

@linbingquan linbingquan marked this pull request as draft February 28, 2021 11:17
linbingquan
linbingquan commented Feb 28, 2021
View reviewed changes
Copy link
Contributor Author

@linbingquan linbingquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This my problem again, I didn't reviewed my code.
I had check it this time. @Mugen87 Thank you for your friendly reminder.

@Mugen87 Mugen87 marked this pull request as ready for review February 28, 2021 12:14
@mrdoob mrdoob added this to the r127 milestone Mar 1, 2021
@mrdoob mrdoob merged commit 6f08c48 into mrdoob:dev Mar 1, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 1, 2021

Thanks!

@linbingquan linbingquan deleted the dev-jsm-prototype branch February 13, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r127
Development

Successfully merging this pull request may close these issues.
3 participants
@linbingquan @mrdoob @Mugen87