Revert to *.prototype.is* = true

[mrdoob]

Related issue: #21284 #21285

[DefinitelyMaybe]

I think I might've confused you and this whole situation. Could someone else please provide some clarity for the related issues.

never mind my guess then

my guess is that:

class foo {
  bar = 1
}

is equivalent to:

class foo {}

foo.prototype.bar =1

[mrdoob]

No. It's not equivalent.

[DefinitelyMaybe]

I'm at a loss on this one. The following works fine in the browser and if I'd understood that earlier I wouldn't have worried about changing as much around as I did with my movements towards classes. We could have gone slower. I apologize @mrdoob.

class foo {
  constructor(param) {
    this.thing = param
  }
}

foo.prototype.value = 1

Object.assign(foo.prototype, {a:'...'})

class bar extends foo { }

Object.assign(bar.prototype, {a:"... ..."})

const y = new foo("aaa")
console.log(y.value);
console.log(y.a);
console.log(y.thing);

const x = new bar("dsa")
console.log(x.value);
console.log(x.a);
console.log(x.thing);

logs:

1
"..."
"aaa"
1
"... ..."
"dsa"

an earlier comment

[DefinitelyMaybe]

#21294

[linbingquan]

There has Object.defineProperty( this, 'is, shell we change it?

[mrdoob]

@linbingquan Actually, I think that'd be great. Please, go ahead and clean that up 🙏