GLTFLoader: Remove support for MSFT_texture_dds. #21271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 13, 2021
|
Sounds good to me 👍 |
|
I think it's good because as Don mentioned basisu texture would be main stream as compressed texture for glTF. And I started this project https://github.com/takahirox/three-gltf-plugins which provides Three.js glTF loader/exporter plugins for the extensions that official Three.js doesn't support. (Anyone, PR for dds texture is welcome there.) |
|
Thanks! |
|
Added https://github.com/takahirox/three-gltf-plugins/tree/main/loaders/MSFT_texture_dds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #13820 (comment) when we added this extension, we do not want to generally provide support for vendor extensions, like a
MSFT_*extension in this case. Multi-vendor extensions (EXT_*) may be considered on a case-by-case basis. We made an exception here because it couldn't be implemented otherwise, and there was no alternative for compressed textures at the time. I'm not sure either of those is true anymore — GLTFLoader has a better plugin system to support customization outside of three.js, and an officialKHR_texture_basisuextension is available now. So, I would suggest that we remove support forMSFT_texture_dds./cc @Bergmam @takahirox