Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFLoader: Fix bug when loading external WebP texture #21282

Merged
merged 6 commits into from
Feb 17, 2021

Conversation

gkjohnson
Copy link
Collaborator

Related issue: --

Description

When loading an external WebP texture file with GLTFLoader and a texture loader is not retrieved with manager.getHandler the loader variable is set to null resulting in an exception. To address it I've changed the logic to mirror what happens in the non-WebP loadTexture function. I found this when looking into a privately shared set of data provided to me to debug an issue with the 3DTilesRendererJS package so unfortunately I cannot share a file for testing but hopefully the logic issue is clear.

cc @donmccurdy

# Conflicts:
#	examples/js/loaders/GLTFLoader.js
#	examples/jsm/loaders/GLTFLoader.js
@mrdoob mrdoob requested a review from donmccurdy February 16, 2021 00:11
@mrdoob mrdoob merged commit a6f08e3 into mrdoob:dev Feb 17, 2021
@mrdoob
Copy link
Owner

mrdoob commented Feb 17, 2021

Thanks!

@mrdoob mrdoob mentioned this pull request Feb 17, 2021
@gkjohnson gkjohnson deleted the gltf-webp-bug branch February 24, 2021 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants