Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: remove useCapture param from addEventListener calls #21110

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Examples: remove useCapture param from addEventListener calls #21110

merged 1 commit into from
Jan 20, 2021

Conversation

marcofugaro
Copy link
Contributor

@marcofugaro marcofugaro commented Jan 19, 2021 •
edited by Mugen87
Loading

Related issue: Fixed #21100

Description

Remove the third parameter from remaining addEventListener calls.

@marcofugaro
Copy link
Contributor Author

@Mugen87 there are some more event listeners in the examples/jsm folder. Should I edit that folder or should I edit the examples/js and then run modularize?

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 20, 2021 •
edited
Loading

or should I edit the examples/js and then run modularize?

Please use this approach.

@mrdoob mrdoob added this to the r125 milestone Jan 20, 2021
@mrdoob mrdoob merged commit e4fe6b8 into mrdoob:dev Jan 20, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jan 20, 2021

Thanks!

@marcofugaro
Copy link
Contributor Author

@Mugen87 done in #21125. We should probably replace the modularize script with an unmodularize one, now that there are more scripts in the jsm folder than the js one.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 21, 2021

see #20527

@Mugen87 Mugen87 mentioned this pull request Jun 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r125
Development

Successfully merging this pull request may close these issues.

Examples: remove addEventListener third parameter
3 participants
@marcofugaro @Mugen87 @mrdoob