Merge pull request #21110 from marcofugaro/addlistener-capture-various

Examples: remove useCapture param from addEventListener calls
mrdoob · Jan 20, 2021 · e4fe6b8 · e4fe6b8
2 parents 2e45bea + c870e1d
commit e4fe6b8
Show file tree

Hide file tree

Showing 94 changed files with 160 additions and 158 deletions.
diff --git a/examples/css3d_molecules.html b/examples/css3d_molecules.html
@@ -175,7 +175,7 @@
 
 					const url = "models/pdb/" + MOLECULES[ m ];
 
-					button.addEventListener( 'click', generateButtonCallback( url ), false );
+					button.addEventListener( 'click', generateButtonCallback( url ) );
 
 				}
 

diff --git a/examples/css3d_panorama.html b/examples/css3d_panorama.html
@@ -88,9 +88,9 @@
 				//
 
 				document.body.style.touchAction = 'none';
-				document.body.addEventListener( 'pointerdown', onPointerDown, false );
+				document.body.addEventListener( 'pointerdown', onPointerDown );
 
-				document.addEventListener( 'wheel', onDocumentMouseWheel, false );
+				document.addEventListener( 'wheel', onDocumentMouseWheel );
 
 				window.addEventListener( 'resize', onWindowResize );
 
@@ -112,8 +112,8 @@
 				pointerX = event.clientX;
 				pointerY = event.clientY;
 
-				document.addEventListener( 'pointermove', onPointerMove, false );
-				document.addEventListener( 'pointerup', onPointerUp, false );
+				document.addEventListener( 'pointermove', onPointerMove );
+				document.addEventListener( 'pointerup', onPointerUp );
 
 			}
 

diff --git a/examples/css3d_panorama_deviceorientation.html b/examples/css3d_panorama_deviceorientation.html
@@ -28,7 +28,7 @@
 				init();
 				animate();
 
-			}, false );
+			} );
 
 			function init() {
 

diff --git a/examples/css3d_periodictable.html b/examples/css3d_periodictable.html
@@ -351,28 +351,28 @@
 
 					transform( targets.table, 2000 );
 
-				}, false );
+				} );
 
 				const buttonSphere = document.getElementById( 'sphere' );
 				buttonSphere.addEventListener( 'click', function () {
 
 					transform( targets.sphere, 2000 );
 
-				}, false );
+				} );
 
 				const buttonHelix = document.getElementById( 'helix' );
 				buttonHelix.addEventListener( 'click', function () {
 
 					transform( targets.helix, 2000 );
 
-				}, false );
+				} );
 
 				const buttonGrid = document.getElementById( 'grid' );
 				buttonGrid.addEventListener( 'click', function () {
 
 					transform( targets.grid, 2000 );
 
-				}, false );
+				} );
 
 				transform( targets.table, 2000 );
 

diff --git a/examples/css3d_sprites.html b/examples/css3d_sprites.html
@@ -64,7 +64,7 @@
 
 					transition();
 
-				}, false );
+				} );
 				image.src = 'textures/sprite.png';
 
 				// Plane

diff --git a/examples/games_fps.html b/examples/games_fps.html
@@ -110,19 +110,19 @@
 
 				keyStates[ event.code ] = true;
 
-			}, false );
+			} );
 
 			document.addEventListener( 'keyup', ( event ) => {
 
 				keyStates[ event.code ] = false;
 
-			}, false );
+			} );
 
 			document.addEventListener( 'mousedown', () => {
 
 				document.body.requestPointerLock();
 
-			}, false );
+			} );
 
 			document.body.addEventListener( 'mousemove', ( event ) => {
 
@@ -133,7 +133,7 @@
 
 				}
 
-			}, false );
+			} );
 
 			window.addEventListener( 'resize', onWindowResize );
 
@@ -157,7 +157,7 @@
 
 				sphereIdx = ( sphereIdx + 1 ) % spheres.length;
 
-			}, false );
+			} );
 
 			function playerCollitions() {
 

diff --git a/examples/misc_controls_deviceorientation.html b/examples/misc_controls_deviceorientation.html
@@ -29,7 +29,7 @@
 				init();
 				animate();
 
-			}, false );
+			} );
 
 			function init() {
 

diff --git a/examples/misc_controls_drag.html b/examples/misc_controls_drag.html
@@ -111,9 +111,9 @@
 
 				window.addEventListener( 'resize', onWindowResize );
 
-				document.addEventListener( 'click', onClick, false );
-				window.addEventListener( 'keydown', onKeyDown, false );
-				window.addEventListener( 'keyup', onKeyUp, false );
+				document.addEventListener( 'click', onClick );
+				window.addEventListener( 'keydown', onKeyDown );
+				window.addEventListener( 'keyup', onKeyUp );
 
 				render();
 

diff --git a/examples/misc_controls_pointerlock.html b/examples/misc_controls_pointerlock.html
@@ -105,7 +105,7 @@
 
 					controls.lock();
 
-				}, false );
+				} );
 
 				controls.addEventListener( 'lock', function () {
 
@@ -184,8 +184,8 @@
 
 				};
 
-				document.addEventListener( 'keydown', onKeyDown, false );
-				document.addEventListener( 'keyup', onKeyUp, false );
+				document.addEventListener( 'keydown', onKeyDown );
+				document.addEventListener( 'keyup', onKeyUp );
 
 				raycaster = new THREE.Raycaster( new THREE.Vector3(), new THREE.Vector3( 0, - 1, 0 ), 0, 10 );
 

diff --git a/examples/misc_exporter_obj.html b/examples/misc_exporter_obj.html
@@ -151,10 +151,10 @@
 
 				addGeometry( 1 );
 
-				window.addEventListener( 'click', onWindowClick, false );
+				window.addEventListener( 'click', onWindowClick );
 				window.addEventListener( 'resize', onWindowResize );
-				document.addEventListener( 'mousemove', onDocumentMouseMove, false );
-				document.addEventListener( 'mouseover', onDocumentMouseMove, false );
+				document.addEventListener( 'mousemove', onDocumentMouseMove );
+				document.addEventListener( 'mouseover', onDocumentMouseMove );
 
 				document.getElementById( 'triangle' ).addEventListener( 'click', function () {
 

diff --git a/examples/misc_lookat.html b/examples/misc_lookat.html
@@ -34,7 +34,7 @@
 			let windowHalfX = window.innerWidth / 2;
 			let windowHalfY = window.innerHeight / 2;
 
-			document.addEventListener( 'mousemove', onDocumentMouseMove, false );
+			document.addEventListener( 'mousemove', onDocumentMouseMove );
 
 			init();
 			animate();

diff --git a/examples/physics_ammo_break.html b/examples/physics_ammo_break.html
@@ -407,7 +407,7 @@
 				pos.multiplyScalar( 24 );
 				ballBody.setLinearVelocity( new Ammo.btVector3( pos.x, pos.y, pos.z ) );
 
-			}, false );
+			} );
 
 		}
 

diff --git a/examples/physics_ammo_cloth.html b/examples/physics_ammo_cloth.html
@@ -363,13 +363,13 @@
 
 					}
 
-				}, false );
+				} );
 
 				window.addEventListener( 'keyup', function () {
 
 					armMovement = 0;
 
-				}, false );
+				} );
 
 			}
 

diff --git a/examples/physics_ammo_rope.html b/examples/physics_ammo_rope.html
@@ -388,13 +388,13 @@
 
 				}
 
-			}, false );
+			} );
 
 			window.addEventListener( 'keyup', function () {
 
 				armMovement = 0;
 
-			}, false );
+			} );
 
 		}
 

diff --git a/examples/physics_ammo_volume.html b/examples/physics_ammo_volume.html
@@ -358,7 +358,7 @@
 
 					}
 
-				}, false );
+				} );
 
 			}
 

diff --git a/examples/webgl_camera.html b/examples/webgl_camera.html
@@ -134,7 +134,7 @@
 				//
 
 				window.addEventListener( 'resize', onWindowResize );
-				document.addEventListener( 'keydown', onKeyDown, false );
+				document.addEventListener( 'keydown', onKeyDown );
 
 			}
 

diff --git a/examples/webgl_camera_cinematic.html b/examples/webgl_camera_cinematic.html
@@ -79,7 +79,7 @@
 				stats = new Stats();
 				document.body.appendChild( stats.dom );
 
-				document.addEventListener( 'mousemove', onDocumentMouseMove, false );
+				document.addEventListener( 'mousemove', onDocumentMouseMove );
 
 				window.addEventListener( 'resize', onWindowResize );
 

diff --git a/examples/webgl_camera_logarithmicdepthbuffer.html b/examples/webgl_camera_logarithmicdepthbuffer.html
@@ -127,9 +127,9 @@
 				border = document.getElementById( 'renderer_border' );
 				border.addEventListener( 'pointerdown', onBorderPointerDown );
 
-				window.addEventListener( 'mousemove', onMouseMove, false );
+				window.addEventListener( 'mousemove', onMouseMove );
 				window.addEventListener( 'resize', onWindowResize );
-				window.addEventListener( 'wheel', onMouseWheel, false );
+				window.addEventListener( 'wheel', onMouseWheel );
 
 			}
 

diff --git a/examples/webgl_decals.html b/examples/webgl_decals.html
@@ -134,7 +134,7 @@
 
 					moved = false;
 
-				}, false );
+				} );
 
 				window.addEventListener( 'pointerup', function ( event ) {
 

diff --git a/examples/webgl_effects_anaglyph.html b/examples/webgl_effects_anaglyph.html
@@ -28,7 +28,7 @@
 			let windowHalfX = window.innerWidth / 2;
 			let windowHalfY = window.innerHeight / 2;
 
-			document.addEventListener( 'mousemove', onDocumentMouseMove, false );
+			document.addEventListener( 'mousemove', onDocumentMouseMove );
 
 			init();
 			animate();

diff --git a/examples/webgl_effects_parallaxbarrier.html b/examples/webgl_effects_parallaxbarrier.html
@@ -29,7 +29,7 @@
 			let windowHalfX = window.innerWidth / 2;
 			let windowHalfY = window.innerHeight / 2;
 
-			document.addEventListener( 'mousemove', onDocumentMouseMove, false );
+			document.addEventListener( 'mousemove', onDocumentMouseMove );
 
 			init();
 			animate();

diff --git a/examples/webgl_effects_stereo.html b/examples/webgl_effects_stereo.html
@@ -27,7 +27,7 @@
 			let windowHalfX = window.innerWidth / 2;
 			let windowHalfY = window.innerHeight / 2;
 
-			document.addEventListener( 'mousemove', onDocumentMouseMove, false );
+			document.addEventListener( 'mousemove', onDocumentMouseMove );
 
 			init();
 			animate();

diff --git a/examples/webgl_geometry_colors.html b/examples/webgl_geometry_colors.html
@@ -156,7 +156,7 @@
 				stats = new Stats();
 				container.appendChild( stats.dom );
 
-				document.addEventListener( 'mousemove', onDocumentMouseMove, false );
+				document.addEventListener( 'mousemove', onDocumentMouseMove );
 
 				//
 

diff --git a/examples/webgl_geometry_hierarchy.html b/examples/webgl_geometry_hierarchy.html
@@ -71,7 +71,7 @@
 
 				//
 
-				document.addEventListener( 'mousemove', onDocumentMouseMove, false );
+				document.addEventListener( 'mousemove', onDocumentMouseMove );
 
 				//
 

diff --git a/examples/webgl_geometry_hierarchy2.html b/examples/webgl_geometry_hierarchy2.html
@@ -126,7 +126,7 @@
 
 				//
 
-				document.addEventListener( 'mousemove', onDocumentMouseMove, false );
+				document.addEventListener( 'mousemove', onDocumentMouseMove );
 
 				//
 

diff --git a/examples/webgl_geometry_nurbs.html b/examples/webgl_geometry_nurbs.html
@@ -170,7 +170,7 @@
 				container.appendChild( stats.dom );
 
 				container.style.touchAction = 'none';
-				container.addEventListener( 'pointerdown', onPointerDown, false );
+				container.addEventListener( 'pointerdown', onPointerDown );
 
 				//
 
@@ -198,8 +198,8 @@
 				pointerXOnPointerDown = event.clientX - windowHalfX;
 				targetRotationOnPointerDown = targetRotation;
 
-				document.addEventListener( 'pointermove', onPointerMove, false );
-				document.addEventListener( 'pointerup', onPointerUp, false );
+				document.addEventListener( 'pointermove', onPointerMove );
+				document.addEventListener( 'pointerup', onPointerUp );
 
 			}
 

diff --git a/examples/webgl_geometry_shapes.html b/examples/webgl_geometry_shapes.html
@@ -353,7 +353,7 @@
 				container.appendChild( stats.dom );
 
 				container.style.touchAction = 'none';
-				container.addEventListener( 'pointerdown', onPointerDown, false );
+				container.addEventListener( 'pointerdown', onPointerDown );
 
 				//
 
@@ -381,8 +381,8 @@
 				pointerXOnPointerDown = event.clientX - windowHalfX;
 				targetRotationOnPointerDown = targetRotation;
 
-				document.addEventListener( 'pointermove', onPointerMove, false );
-				document.addEventListener( 'pointerup', onPointerUp, false );
+				document.addEventListener( 'pointermove', onPointerMove );
+				document.addEventListener( 'pointerup', onPointerUp );
 
 			}
 

diff --git a/examples/webgl_geometry_spline_editor.html b/examples/webgl_geometry_spline_editor.html
@@ -147,9 +147,9 @@
 
 				} );
 
-				document.addEventListener( 'pointerdown', onPointerDown, false );
-				document.addEventListener( 'pointerup', onPointerUp, false );
-				document.addEventListener( 'pointermove', onPointerMove, false );
+				document.addEventListener( 'pointerdown', onPointerDown );
+				document.addEventListener( 'pointerup', onPointerUp );
+				document.addEventListener( 'pointermove', onPointerMove );
 
 				/*******
 				 * Curves

diff --git a/examples/webgl_geometry_terrain_raycast.html b/examples/webgl_geometry_terrain_raycast.html
@@ -103,7 +103,7 @@
 				helper = new THREE.Mesh( geometryHelper, new THREE.MeshNormalMaterial() );
 				scene.add( helper );
 
-				container.addEventListener( 'mousemove', onMouseMove, false );
+				container.addEventListener( 'mousemove', onMouseMove );
 
 				stats = new Stats();
 				container.appendChild( stats.dom );
-Original file line number
+Diff line change
@@ Expand Up / @@ -175,7 +175,7 @@ @@
     					const url = "models/pdb/" + MOLECULES[ m ];
-    					button.addEventListener( 'click', generateButtonCallback( url ), false );
+    					button.addEventListener( 'click', generateButtonCallback( url ) );
     				}
@@ Expand Down @@