Adds run command -> install and launch extension #90
Conversation
|
This pattern of adding |
|
@kumar303 I think that we need to add to the cli a new "--firefox-bin" option (as a non mandatory option), because the firefox binary auto-discovery sometimes fails to find the correct path to the firefox executable (e.g. on my ubuntu it decides that the binary should be /usr/lib64/firefox, which doesn't even exist on my system) |
| let readStream = nodeFs.createReadStream(extensionPath); | ||
| let id = manifestData.applications.gecko.id; | ||
|
|
||
| // TODO: also support copying a direcotry of code to this |
Yep, adding that in #71 |
| @@ -37,6 +37,8 @@ | |||
| "babel-polyfill": "6.6.1", | |||
| "es6-error": "2.0.2", | |||
| "es6-promisify": "3.0.0", | |||
| "firefox-profile": "^0.3.11", | |||
There was a problem hiding this comment.
@kumar303 This should be turned into an exact version match
| }); | ||
|
|
||
| firefox.stderr.on('data', (data) => { | ||
| console.log(`stdout: ${data.toString().trim()}`); |
|
@kumar303 great! this PR looks ready. I'm so happy that I can now run a webextension addon without leaving the command line :-) |
|
Thanks for the review! Yes, definitely let me know how it works for you. There are, of course, a lot of missing features (a lot of issues filed). |
Adds run command -> install and launch extension
Fixes #6