Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a logger #33

Closed
kumar303 opened this issue Feb 8, 2016 · 3 comments · Fixed by #160
Closed

Add a logger #33

kumar303 opened this issue Feb 8, 2016 · 3 comments · Fixed by #160
Assignees
@kumar303

Comments

@kumar303
Copy link
Contributor

kumar303 commented Feb 8, 2016

We need a logger for all web-ext commands, one that can be configured for verbose logging.
@kumar303 kumar303 mentioned this issue Feb 11, 2016
Merged
@kumar303 kumar303 self-assigned this Feb 11, 2016
@muffinresearch
Copy link
Contributor

Having been using bunyan on addons-linter I quite like it and would recommend it. It's very easy to use and has configurable levels. Also has a binary for nicer formatting of the messages which is useful sometimes.

@kumar303
Copy link
Contributor Author

kumar303 commented Mar 1, 2016

Note to self: it would be nice if web-ext dumped a verbose error log in the case of an unexpected exception.

This was referenced Mar 2, 2016
Merged
Closed
@kumar303 kumar303 mentioned this issue Mar 22, 2016
Merged
@kumar303
Copy link
Contributor Author

it would be nice if web-ext dumped a verbose error log in the case of an unexpected exception.

We could use bunyan.RingBuffer for this

This was referenced Mar 28, 2016
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumar303 kumar303

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds a logger and implements --verbose kumar303/web-ext
2 participants
@muffinresearch @kumar303