-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command to sign web extensions #151
Conversation
There's no point in managing two linters. Also, jscs is choking on some Flow syntax.
60a1c25
to
3d9359a
Compare
return sign(tmpDir.path(), stubs) | ||
.then(() => { | ||
assert.equal(stubs.signAddon.called, true); | ||
assert.equal(stubs.signAddon.firstCall.args[0].apiKey, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, how about assigning stubs.signAddon.firstCall.args[0]
to a shorter variable name (e.g. let signAddonArg = ...
) to make this sequence of assertions a bit more readable?
looks good to me NOTE: tests are currently failing on travis because the sign-addon package is not yet on the npm registry, but they successfully complete locally, by linking the sign-addon into the local node_modules dir. |
The tests are passing after I published |
Fixes #145
NOTE: this depends on mozilla/sign-addon#14 which also needs to be released to NPM before the tests in this pull request will pass.
signing works!