Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command to sign a web extension #145

Closed
kumar303 opened this issue Mar 21, 2016 · 6 comments · Fixed by #151
Closed

Add command to sign a web extension #145

kumar303 opened this issue Mar 21, 2016 · 6 comments · Fixed by #151
Assignees
@kumar303

Comments

@kumar303
Copy link
Contributor

Similar to jpm sign, one should be able to run web-ext sign to build and sign the extension.
@kumar303 kumar303 self-assigned this Mar 21, 2016
@kumar303
Copy link
Contributor Author

The jpm signing parts have been extracted to https://github.com/mozilla/sign-addon

@kumar303 kumar303 mentioned this issue Mar 23, 2016
Closed
@jc3213
Copy link

jc3213 commented Mar 24, 2016

@kumar303 could we still use jpm sign to sign addons?

@kumar303
Copy link
Contributor Author

Yes, of course! But jpm sign will only work for SDK add-ons and pre-SDK add-ons. It will not support web extensions.

@jc3213
Copy link

jc3213 commented Mar 24, 2016

Then this node lib is to sign all types of add-ons, including SDK or pre-SDK ones?

@kumar303 kumar303 mentioned this issue Mar 25, 2016
Merged
@kumar303 kumar303 self-assigned this Mar 25, 2016
@kumar303
Copy link
Contributor Author

jpm sign will always support signing SDK add-ons. At first, jpm will also sign older install.rdf add-ons. However, in the future I think older add-ons will need to use the sign-addon command directly.

@kumar303 kumar303 mentioned this issue Mar 31, 2016
Closed
@kumar303
Copy link
Contributor Author

kumar303 commented May 4, 2016

This is documented now https://developer.mozilla.org/en-US/Add-ons/WebExtensions/web-ext_command_reference#web-ext_sign

@snyk-bot snyk-bot mentioned this issue Jun 7, 2021
Open
@terrorizer1980 terrorizer1980 mentioned this issue Apr 21, 2022
Open
@snyk-bot snyk-bot mentioned this issue Oct 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumar303 kumar303

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Command to sign web extensions kumar303/web-ext
2 participants
@kumar303 @jc3213