Make the $262 object available within the test262 tests #1229
Conversation
|
Added this PR quickly as it might come in handly for #1227 |
Fix $262 object
| this.scope = scope; | ||
|
|
||
| scope.put("$262", scope, this); | ||
| scope.setAttributes("$262", ScriptableObject.DONTENUM); |
There was a problem hiding this comment.
I think the scope setup should be done in the setup and mot in the ctor.
There was a problem hiding this comment.
With setup you mean moving the code into the .buildScope() method?
That would entail duplicating the code between there and the $262.createRealm method, which i don't really like either
There was a problem hiding this comment.
Ok, is see, my problem was as i saw this line
new $262(scope);
i was really confused because i did not expect that this ctor call does some kind of registration in the scope. So from the first look this line looks really useless.
Maybe a factory method that has a hint in the name about the registration?
|
Any idea why there is no real effect? |
|
Btw. i think this is again great step forward for Rhino - THANKS. |
|
There is an effect now no? Some previously failing tests are now passing. I guess you mean why aren't more of the tests that depended on cross-realm passing now? Can't recall, but when I looked into it a while ago, they were failing due to other reasons. I filled for example #1079, because that is an EcmaScript incompatibility when using Symbols cross-realm |
|
This PR also needs a squash merge.... |
|
@rbri great, tnx for the review. Can you squash-merge this PR? |
|
Yes I can :-) |
Closes #1077
PR not yet complete: needs at least the test262.properties file regenerated