Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix symbol impl to have the GlobalSymbolRegistry shared between Realms #1079

Open
p-bakker opened this issue Oct 26, 2021 · 0 comments
Open

Fix symbol impl to have the GlobalSymbolRegistry shared between Realms #1079

p-bakker opened this issue Oct 26, 2021 · 0 comments
Labels
behavior bug Issues considered a bug Ecma Incompatibility Issues about Rhino being incompatible with the EcmaScript spec

Comments

@p-bakker
Copy link
Collaborator

p-bakker commented Oct 26, 2021 •
edited
Loading

Current implementation keeps the GlobalSymbolRegistry in the topLevel scope.

However, EcmaScript defines that the GlobalSymbolRegistry needs to be shared by all Realms, which basically translates to: each topLevel scope must share the same GlobalSymbolRegistry

Note: need to see how such a global registery would work in combination with shared sealed scopes

Depends on #1077 (for enabled the cross-realm tests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
behavior bug Issues considered a bug Ecma Incompatibility Issues about Rhino being incompatible with the EcmaScript spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p-bakker