Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load checkpoint callback #1570

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented Oct 5, 2024

Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request a test that the callback can be instantiated (will also force this PR to wait until the next composer release)

@irenedea
Copy link
Contributor Author

irenedea commented Oct 5, 2024

@dakinggg do we do this for other callbacks? Shouldn't instantiation be covered by whether or not I can import it (which it's failing until the composer release is out) and registry tests?

@dakinggg
Copy link
Collaborator

dakinggg commented Oct 5, 2024

@irenedea I don't think we've been super consistent (and you're right that the import covers what I said), but I tend try to write a simple instantiation test for things too (e.g.

def test_system_metrics_monitor_callback_builds():
). Possibly should just write a single parametrized test that iterates over all the callbacks and tries to instantiate them.

@irenedea
Copy link
Contributor Author

irenedea commented Oct 7, 2024

@dakinggg added generic test for callback building here #1577

@irenedea irenedea marked this pull request as ready for review October 28, 2024 18:59
@irenedea irenedea requested a review from a team as a code owner October 28, 2024 18:59
@irenedea irenedea enabled auto-merge (squash) October 28, 2024 19:00
@irenedea irenedea merged commit 3eb5cea into mosaicml:main Oct 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants