-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create callback to load checkpoint #3641
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irenedea
force-pushed
the
load-checkpoint-callback
branch
from
October 1, 2024 07:19
00682c7
to
758314d
Compare
irenedea
force-pushed
the
load-checkpoint-callback
branch
from
October 3, 2024 21:13
8624131
to
71976bf
Compare
irenedea
force-pushed
the
load-checkpoint-callback
branch
from
October 3, 2024 22:42
71976bf
to
c40e7cc
Compare
irenedea
force-pushed
the
load-checkpoint-callback
branch
from
October 4, 2024 22:52
a3a8dd9
to
9eb9c50
Compare
dakinggg
approved these changes
Oct 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks right to me
mvpatel2000
reviewed
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new callback to load a checkpoint at a specified event. This enables use cases like loading model base weights with peft.
Manual Test
Ran two lora finetuning runs.
test-load-checkpoint-callback-baseline-K0m4fq
: Initialized from Huggingface checkpoint and ran for 100 batchestest-load-checkpoint-callback-resume-GS8oWj
: Initialized using this callback and the baseline checkpoint at ba50.We see that the losses match up.
Also confirmed that the adapter-only checkpoint is smaller than a full checkpoint as expected.
What issue(s) does this change relate to?
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)