Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable gcs azure daily test #3514

Merged
merged 7 commits into from
Aug 2, 2024
Merged

Disable gcs azure daily test #3514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3f2e162
a
bigning Aug 1, 2024
bd98ff4
a
bigning Aug 1, 2024
76298ff
lint
bigning Aug 1, 2024
05bb403
Update tests/utils/object_store/test_azure_object_store.py
bigning Aug 2, 2024
8b24d2f
Update tests/utils/object_store/test_gs_object_store.py
bigning Aug 2, 2024
62dbd74
Update tests/utils/object_store/test_gs_object_store.py
bigning Aug 2, 2024
cca2066
Merge branch 'dev' into disable_gcs_azure
dakinggg Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/utils/object_store/test_azure_object_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@


@pytest.mark.remote
@pytest.mark.skip(reason='Waiting for new Azure key to be approved')
def test_azure_object_store_integration():
model = SimpleModel()
train_dataloader = DataLoader(dataset=RandomClassificationDataset())
Expand Down
2 changes: 2 additions & 0 deletions tests/utils/object_store/test_gs_object_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ def get_gcs_os_from_trainer(trainer: Trainer) -> GCSObjectStore:

@pytest.mark.gpu # json auth is hard to set up on github actions / CPU tests
@pytest.mark.remote
@pytest.mark.skip(reason='Waiting for new GCP key to be approved')
def test_gs_object_store_integration_hmac_auth(expected_use_gcs_sdk_val=False, client_should_be_none=True):
model = SimpleModel()
train_dataset = RandomClassificationDataset()
Expand Down Expand Up @@ -63,6 +64,7 @@ def test_gs_object_store_integration_hmac_auth(expected_use_gcs_sdk_val=False, c

@pytest.mark.gpu
@pytest.mark.remote
@pytest.mark.skip(reason='Waiting for new GCP key to be approved')
def test_gs_object_store_integration_json_auth():
with mock.patch.dict(os.environ):
if 'GCS_KEY' in os.environ:
Expand Down
Loading