Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable gcs azure daily test #3514

Merged
merged 7 commits into from
Aug 2, 2024
Merged

Disable gcs azure daily test #3514

merged 7 commits into from
Aug 2, 2024

Conversation

bigning
Copy link
Contributor

@bigning bigning commented Aug 1, 2024

For GCS key, we're waiting for the request https://databricks.atlassian.net/browse/SOPS-719?focusedCommentId=5299281

For Azure, @j316chuck will start the request once we go through the GCS request process.

before cpu test failure:

https://github.com/mosaicml/composer/actions/runs/10207147591
image

after cpu tests succeed:

[gpu tests still running] https://github.com/mosaicml/composer/actions/runs/10207236494
image

@bigning bigning changed the title Disable gcs azure Disable gcs azure daily test Aug 1, 2024
@bigning bigning marked this pull request as ready for review August 1, 2024 23:57
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minor comments + quick stamp

tests/utils/object_store/test_azure_object_store.py Outdated Show resolved Hide resolved
tests/utils/object_store/test_gs_object_store.py Outdated Show resolved Hide resolved
tests/utils/object_store/test_gs_object_store.py Outdated Show resolved Hide resolved
@bigning bigning enabled auto-merge (squash) August 2, 2024 00:15
@bigning bigning merged commit a63321b into dev Aug 2, 2024
14 checks passed
@bigning bigning deleted the disable_gcs_azure branch August 2, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants