🐛 Use 100 for the default value of impact #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for impact to be be nil, in which case we should use the default value which is 100. Using the score value doesn't make sense. It would mean that the category would change based on if it passed or failed in cases where impact was not defined.
Test Results 1 files 27 suites 1m 3s ⏱️ Results for commit 1990fef. |
czunker
reviewed
Dec 11, 2024
Comment on lines
+290
to
+294
| {Value: nil}, | ||
| // 10 high checks | ||
| {Value: &explorer.ImpactValue{Value: 80}}, | ||
| }, | ||
| out: &Score{Value: 45, ScoreCompletion: 100, DataCompletion: 66, Weight: 20, Type: ScoreType_Result}, |
There was a problem hiding this comment.
I don't understand this part of the test.
The previous test (L273) uses impact 100. The PR description states that we use 100 for impact, when it is nil.
Shouldn't the scores be the same in the two tests? L277 vs. L294
There was a problem hiding this comment.
i copied the test on 243. This one is slightly different than the one that is directly before. score values 0, 100, 0 vs 0, 100, 100
czunker
approved these changes
Dec 11, 2024
Comment on lines
+290
to
+294
| {Value: nil}, | ||
| // 10 high checks | ||
| {Value: &explorer.ImpactValue{Value: 80}}, | ||
| }, | ||
| out: &Score{Value: 45, ScoreCompletion: 100, DataCompletion: 66, Weight: 20, Type: ScoreType_Result}, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for impact to be be nil, in which case we should use the default value which is 100. Using the score value doesn't make sense. It would mean that the category would change based on if it passed or failed in cases where impact was not defined.