🐛 load flags via viper/cnquery providers #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based of mondoohq/cnquery#4863 where we now properly load provider flags via `viper` and from environment variables, we depend of the viper binding of such flags and, since `cnspec` did not have a `PreRun()` function but a `PreRunE()`, we did not load them. This simple change fixes that issue and we now load the flags since we have the `PreRun()` function now, very similar to the code in `cnquery` at: https://github.com/mondoohq/cnquery/blob/main/apps/cnquery/cmd/scan.go#L88 Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
force-pushed
the
afiune/flags-not-loading
branch
from
8527f5b to
89915aa
Compare
Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
force-pushed
the
afiune/flags-not-loading
branch
from
89915aa to
75a1872
Compare
jaym
approved these changes
Dec 4, 2024
afiune
force-pushed
the
afiune/flags-not-loading
branch
from
b936e1b to
fb201aa
Compare
Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
force-pushed
the
afiune/flags-not-loading
branch
from
fb201aa to
6f391cd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Holy 🐮 cow! Are you ready for this fix!??
Based of mondoohq/cnquery#4863 where we now properly load provider flags via
viperand from environment variables, we depend of the viper binding of such flags and, sincecnspecdid not have aPreRun()function but aPreRunE(), we did not load them.This simple change fixes that issue, we now load the flags since we have the
PreRun()function that is required to bind our flags at https://github.com/mondoohq/cnquery/blob/main/cli/providers/providers.go#L378-L399This code is very similar to the code in
cnqueryat:https://github.com/mondoohq/cnquery/blob/main/apps/cnquery/cmd/scan.go#L88