🐛 bring back loading provider flags from env vars #4863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a provider defines a flag with `ConfigEntry = "-"`, then we do not Bind the Flag to the `viper` config. For those flags, we will continue to fetch the value directly from the flag, that is, from `cobra`. Signed-off-by: Salim Afiune Maya <[email protected]>
jaym
reviewed
Nov 25, 2024
test/providers/os_test.go
Outdated
| } | ||
| }) | ||
|
|
||
| t.Run("command with flags set to not bind to config (ConfigEntry=\"-\")", func(t *testing.T) { |
jaym
approved these changes
Nov 25, 2024
afiune
commented
Nov 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem from my original PR #4847 to load provider flags from environment
variables was that I didn't consider the case where a provider defines a flag with
ConfigEntry = "-". For those cases, we do NOT bind the flag to theviperconfigand therefore, we couldn't load these flags.
This PR fixes that issue and, for those flags that are not bind to the config, we will
continue to fetch the value directly from the flag itself, that is, from
cobra.