-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.8 #2500
Changes from all commits
abb8a32
a06bd1e
0d482a4
90a2a25
43d938e
5463b8b
78c1de9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,7 @@ jobs: | |
strategy: | ||
fail-fast: false # run all variants across python versions/os to completion | ||
matrix: | ||
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"] | ||
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"] | ||
os: ["ubuntu-20.04"] | ||
proto-version: ["latest"] | ||
include: | ||
|
@@ -38,7 +38,7 @@ jobs: | |
python-version: "3.10" | ||
proto-version: "latest" | ||
- os: "ubuntu-20.04" | ||
python-version: "3.8" | ||
python-version: "3.9" | ||
proto-version: "3.19" | ||
|
||
runs-on: ${{ matrix.os }} | ||
|
@@ -77,11 +77,23 @@ jobs: | |
timeout-minutes: 4 | ||
strategy: | ||
matrix: | ||
image-builder-version: ["2024.04", "2024.10"] | ||
python-version: ["3.8", "3.13"] | ||
include: | ||
- image-builder-version: "2024.04" | ||
python-version: "3.9" | ||
- image-builder-version: "2024.04" | ||
python-version: "3.12" | ||
- image-builder-version: "2024.10" | ||
python-version: "3.9" | ||
- image-builder-version: "2024.10" | ||
python-version: "3.13" | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- uses: actions/setup-python@v5 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
|
||
- name: Install dependencies | ||
run: | | ||
pip install -r modal/requirements/${{ matrix.image-builder-version }}.txt | ||
|
@@ -91,7 +103,13 @@ jobs: | |
run: | | ||
python -m venv venv | ||
source venv/bin/activate | ||
pip install grpcio-tools==1.59.2 grpclib==0.4.7 | ||
if [ "${{ matrix.python-version }}" == "3.9" ]; then | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: Our published package has the same generated protos regardless of the python version of the client that ends up using it right? So maybe this should use the same python and versions as we do when publishing? (a bit messy to switch versions etc, but relatively easy with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This check is just meant to assert that we haven't added any third-party dependencies to |
||
pip install grpcio-tools==1.48.2 grpclib==0.4.7; | ||
elif [ "${{ matrix.python-version }}" == "3.12" ]; then | ||
pip install grpcio-tools==1.59.2 grpclib==0.4.7; | ||
elif [ "${{ matrix.python-version }}" == "3.13" ]; then | ||
pip install grpcio-tools==1.66.2 grpclib==0.4.7; | ||
fi | ||
python -m grpc_tools.protoc --python_out=. --grpclib_python_out=. --grpc_python_out=. -I . modal_proto/api.proto modal_proto/options.proto | ||
python -m grpc_tools.protoc --plugin=protoc-gen-modal-grpclib-python=protoc_plugin/plugin.py --modal-grpclib-python_out=. -I . modal_proto/api.proto modal_proto/options.proto | ||
deactivate | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# Copyright Modal Labs 2024 | ||
|
||
# Note: Reset this value to -1 whenever you make a minor `0.X` release of the client. | ||
build_number = 66 # git: 875cc88 | ||
build_number = -1 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1088,7 +1088,7 @@ def get_hash(img: Image) -> str: | |
spec_file=test_dir / "supports" / "test-conda-environment.yml", | ||
channels=["conda-forge", "my-channel"], | ||
) | ||
assert get_hash(img) == "d9d4c9fe24769ce587877b9752a64486e8f7d8520731110bd2fa666de82f43fd" | ||
assert get_hash(img) == "f8701ce500d6aa1fecefd9c2869aef4a13c77ab03925333c011d7eca60bbf08a" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't a real change to the Image recipe, but the |
||
|
||
img = base.poetry_install_from_file( | ||
test_dir / "supports" / "test-pyproject.toml", | ||
|
@@ -1156,7 +1156,7 @@ def get_hash(img: Image) -> str: | |
spec_file=test_dir / "supports" / "test-conda-environment.yml", | ||
channels=["conda-forge", "my-channel"], | ||
) | ||
assert get_hash(img) == "769bdbb5aaeb4f6c7eda77e59ee81c6adac9b03ff7e479036b83ec414e8cfec6" | ||
assert get_hash(img) == "072e70b2f05327f606c261ad48a68cf8db5e592e7019f6ee7dbaccf28f2ef537" | ||
|
||
img = base.poetry_install_from_file( | ||
test_dir / "supports" / "test-pyproject.toml", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ channels: | |
- pytorch | ||
- defaults | ||
dependencies: | ||
- python=3.8.5 | ||
- python=3.12.5 | ||
- foo=1.0 | ||
- pip: | ||
- bar=2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, we were always running this check on 3.8 anyway...