Drop support for Python 3.8 #2500
Conversation
| @@ -1063,7 +1063,7 @@ def get_hash(img: Image) -> str: | |||
| spec_file=test_dir / "supports" / "test-conda-environment.yml", | |||
| channels=["conda-forge", "my-channel"], | |||
| ) | |||
| assert get_hash(img) == "d9d4c9fe24769ce587877b9752a64486e8f7d8520731110bd2fa666de82f43fd" | |||
| assert get_hash(img) == "f8701ce500d6aa1fecefd9c2869aef4a13c77ab03925333c011d7eca60bbf08a" | |||
There was a problem hiding this comment.
This isn't a real change to the Image recipe, but the test-conda-environment.yml support file we use had python_version: 3.8, which I've updated to avoid other issues.
mwaskom
force-pushed
the
michael/drop-py38
branch
from
4166f0a to
65fedd9
Compare
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} |
There was a problem hiding this comment.
Whoops, we were always running this check on 3.8 anyway...
mwaskom
force-pushed
the
michael/drop-py38
branch
5 times, most recently
from
cae63bb to
9a8ffe5
Compare
|
looks good! Looking forward to removing the |
|
🪓 |
| @@ -91,7 +103,13 @@ jobs: | |||
| run: | | |||
| python -m venv venv | |||
| source venv/bin/activate | |||
| pip install grpcio-tools==1.59.2 grpclib==0.4.7 | |||
| if [ "${{ matrix.python-version }}" == "3.9" ]; then | |||
There was a problem hiding this comment.
Nit: Our published package has the same generated protos regardless of the python version of the client that ends up using it right? So maybe this should use the same python and versions as we do when publishing? (a bit messy to switch versions etc, but relatively easy with uv as a python manager)
There was a problem hiding this comment.
This check is just meant to assert that we haven't added any third-party dependencies to python -m modal._container_entrypoint that aren't in the expected container requirements, so the specific way that we compile the protos isn't super important because whatever choice we make wouldn't introduce transitive dependencies. But (as we're discussing on Slack) there definitely are larger and trickier questions about our proto packaging!
…iner dependencies
…on <> builder_version
mwaskom
force-pushed
the
michael/drop-py38
branch
from
3fcf122 to
78c1de9
Compare
Yeah the workflow where subsequent commits introduce a merge conflict with the "reset the micro version" diff is annoying. I've been meaning to automate that (i.e. just detect a minor version bump and handle the micro version accordingly) in the CD workflow but it doesn't happen quite often enough to make that feel worthwhile... |
Closes CLI-10
Changelog