Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update stages and build matrices #3308

Merged
merged 8 commits into from
Apr 4, 2018
Merged

update stages and build matrices #3308

merged 8 commits into from
Apr 4, 2018

Conversation

boneskull
Copy link
Contributor

  • fiddle with caching
    • don't cache for smoke tests
    • npm@5 comes with node@8 or newer, so cache ~/.npm as well
    • otherwise, don't.
  • smoke test for each node.js version (stage 1)
  • lint (stage 2)
  • tests for each node.js version and browsers (stage 3)
  • addons (artifacts, sauce labs, chrome) are only present for browser tests!

YAML aliases are basically voodoo.

boneskull added 5 commits April 3, 2018 23:35
@boneskull
optimize build stages and jobs
866af71 
Signed-off-by: Christopher Hiller <[email protected]>
@boneskull
attempt to avoid $TARGET
e621454 
Signed-off-by: Christopher Hiller <[email protected]>
@boneskull
run smoke tests across multiple node versions
ac83752 
Signed-off-by: Christopher Hiller <[email protected]>
@boneskull
can I define addons per-job?
497c20c 
Signed-off-by: Christopher Hiller <[email protected]>
@boneskull
more aliases
2b0e286 
Signed-off-by: Christopher Hiller <[email protected]>
@boneskull boneskull added qa semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Apr 4, 2018
@boneskull boneskull requested a review from outsideris April 4, 2018 07:37
@boneskull boneskull force-pushed the experimental/travis branch from 21c01da to 1383060 Compare April 4, 2018 07:47
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.955% when pulling 1383060 on experimental/travis into f2560e7 on master.

@outsideris
Copy link
Contributor

It looks good!

There is one thing.

2018-04-05 00 39 25

It's hard to distinguish test.node and test.browser with node 9. Setting environment varibles can address this.
What do you think?

@boneskull
Copy link
Contributor Author

I raised this issue with Travis CI. If I set an environment variable then the cache can not be reused between the node and browser tests. There’s unfortunately no other way to distinguish them except to add a new stage at this point. Or just don’t worry about the caching

outsideris
outsideris approved these changes Apr 4, 2018
View reviewed changes
Copy link
Contributor

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it. I hope that TravisCI addresses the problem.

@boneskull boneskull merged commit ff9f3cf into master Apr 4, 2018
@boneskull boneskull deleted the experimental/travis branch April 4, 2018 18:11
@boneskull boneskull added this to the v5.1.0 milestone Apr 7, 2018
@dependencies dependencies bot mentioned this pull request Apr 13, 2018
Merged
@renovate renovate bot mentioned this pull request Apr 17, 2018
Merged
This was referenced Sep 22, 2018
Closed
Closed
Closed
Open
Open
Closed
Closed
Closed
Closed
This was referenced Oct 2, 2018
Closed
Closed
Open
Merged
This was referenced Oct 25, 2018
Merged
Merged
Closed
Closed
This was referenced Nov 1, 2018
Merged
Merged
Merged
This was referenced Nov 9, 2018
Merged
Closed
Merged
This was referenced Nov 19, 2018
Closed
Merged
This was referenced Dec 1, 2018
Closed
Merged
Merged
This was referenced Dec 8, 2018
Merged
Closed
Merged
Closed
This was referenced Dec 23, 2018
Closed
Closed
sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019
@boneskull
update stages and build matrices (mochajs#3308)
d550606 
* optimize build stages and jobs
* attempt to avoid $TARGET
* run smoke tests across multiple node versions
* define addons per-job
* disable caching for smoke tests; avoid alias
* disable caching for older node versions entirely
* combine bundle / browser tests; do not run extra node 9 job

Signed-off-by: Christopher Hiller <[email protected]>
This was referenced Mar 14, 2020
Closed
Closed
Closed
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsideris outsideris outsideris approved these changes

Assignees
No one assigned
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@boneskull @coveralls @outsideris