-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all sample-based Cue methods #4061
Conversation
8041c41
to
e6236cd
Compare
a0c8f60
to
8f031b4
Compare
0d09df3
to
09fe05b
Compare
These methods are now unused.
Pull Request Test Coverage Report for Build 1020805526
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Currently AutoDJ crashes Mixxx completely with a segfault when using "Enable random track addition to queue". It started crashing with this commit or the ones referred to in the first comment I believe a couple days after committing #4041... Let me know if we need to file a new bug on Launchpad. Thx |
That is unrelated to this PR, please report a bug on Launchpad. |
@Be-ing Thanks for the quick reply, I opened one : https://bugs.launchpad.net/mixxx/+bug/1936396 |
Based on #4049. This changes the Cue API to use frame positions.
Prerequisite PRs:
This is extremely weird. Only the last commit is of interest (the other ones are part of other PRs). That last commit makes a bunch of test cases time out, and I have no idea why.EDIT The commit seems to cause an endless loop inTrack::setCuePointsWhileLocked
. Investigating.EDIT 2 Looks like I'm not the brightest candle on the cake:No wonder there is an endless loop :)EDIT 3 Fixed.