Beats frame refactor #4049
Merged
Beats frame refactor #4049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
force-pushed
the
beats-frame-refactor
branch
2 times, most recently
from
4a294dc to
926f970
Compare
10 tasks
The method returns a mixxx::audio::FramePos value, so mentioning the unit in the method name is unnecessary.
Holzhaus
force-pushed
the
beats-frame-refactor
branch
from
926f970 to
75b2752
Compare
|
Ready to review. Sorry the diff is so large :-/ |
uklotzde
reviewed
Jul 6, 2021
uklotzde
suggested changes
Jul 6, 2021
uklotzde
approved these changes
Jul 6, 2021
|
If someone wants to double check then please do. Otherwise let's merge it soon. |
|
If anyone finds an issue afterwards it should be trivial to fix. LGTM |
Holzhaus
added a commit
to Holzhaus/mixxx
that referenced
this pull request
Jul 20, 2021
The beatgrid now uses frames, so this multiplication results in a beatgrid of half the intended BPM. This was an oversight from mixxxdj#4049.
Holzhaus
added a commit
to Holzhaus/mixxx
that referenced
this pull request
Jul 20, 2021
The beatgrid now uses frames, so this multiplication results in a beatgrid of half the intended BPM. This was an oversight from mixxxdj#4049.
Holzhaus
added a commit
to Holzhaus/mixxx
that referenced
this pull request
Jul 20, 2021
The beatgrid now uses frames, so this multiplication results in a beatgrid of half the intended BPM. This was an oversight from mixxxdj#4049.
Holzhaus
added a commit
to Holzhaus/mixxx
that referenced
this pull request
Jul 24, 2021
The beatgrid now uses frames, so this multiplication results in a beatgrid of half the intended BPM. This was an oversight from mixxxdj#4049.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4048.
This changes the Beats object to return the FramePos type from all methods that return positions.
I tried to keep the changes in the calling code as small as possible, which admittedly makes this code quite ugly with all this back/forth conversion. But otherwise it would be much more work and the diff would be huge.
This PR makes it possible to migrate the other features to the framepos type independently later on, which is taken care of in #4061 for example.